Github user rdowner commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/926#discussion_r160127430
  
    --- Diff: 
locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/JcloudsSshMachineLocationStubbedTest.java
 ---
    @@ -76,29 +76,12 @@ public FailObtainOnPurposeException(String message) {
         @BeforeMethod(alwaysRun=true)
         public void setUp() throws Exception {
             super.setUp();
    -        privateAddresses = ImmutableList.of("172.168.10.11");
    -        publicAddresses = ImmutableList.of("173.194.32.123");
    -        initNodeCreatorAndJcloudsLocation(newNodeCreator(), 
ImmutableMap.of());
    +        privateAddresses = ImmutableList.of(PRIVATE_IP_ADDRESS);
    +        publicAddresses = ImmutableList.of(PUBLIC_IP_ADDRESS);
    +        jcloudsLocation = initStubbedJcloudsLocation(ImmutableMap.of());
         }
         
    -    @Override
    -    protected NodeCreator newNodeCreator() {
    -        return new AbstractNodeCreator() {
    -            @Override protected NodeMetadata newNode(String group, 
Template template) {
    -                NodeMetadata result = new NodeMetadataBuilder()
    -                        .id("myid")
    -                        
.credentials(LoginCredentials.builder().identity("myuser").credential("mypassword").build())
    -                        .loginPort(22)
    -                        .status(Status.RUNNING)
    -                        .publicAddresses(publicAddresses)
    -                        .privateAddresses(privateAddresses)
    -                        .build();
    -                return result;
    -            }
    -        };
    -    }
    -
    -    @Test
    +    @Test(enabled = false)
    --- End diff --
    
    Is there a reason for disabling this test? If so, please add a comment.


---

Reply via email to