ASF GitHub Bot commented on BROOKLYN-580:

GitHub user aledsage opened a pull request:


    BROOKLYN-580 rebind machine entity feeds

    Fixes https://issues.apache.org/jira/browse/BROOKLYN-580

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server 

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #947
commit 1af80984becd6cce5f4c5e43d202927af5dc9540
Author: Aled Sage <aled.sage@...>
Date:   2018-02-09T10:00:24Z

    Add RebindManager.isRebindActive

commit 9e7e83a4f4fb71393e5db03317c60db44bff14cc
Author: Aled Sage <aled.sage@...>
Date:   2018-02-09T10:02:28Z

    MachineEntity: get locations from ancestors if necessary
    And improve logging.

commit c68f848567711c4d78e8b11bcb58c990a2c2d8e7
Author: Aled Sage <aled.sage@...>
Date:   2018-02-09T10:03:16Z

    BROOKLYN-580: fix calling connect-sensors on rebind


> Rebinding to MachineEntity: sometimes fails to reconnect sensor feeds
> ---------------------------------------------------------------------
>                 Key: BROOKLYN-580
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-580
>             Project: Brooklyn
>          Issue Type: Bug
>    Affects Versions: 0.12.0
>            Reporter: Aled Sage
>            Priority: Major
> On rebind, sometimes \{{MachineEntity}} instances do not have their feeds 
> recreated. This is illustrated by non-deterministic test failure in 
> \{{MachineEntityJcloudsRebindTest}}.
> The problem is that \{{SoftwareProcessImpl.callRebindHooks}} schedules a task 
> to call \{{connectSensors}} in something between 0 and 10 seconds time, which 
> will try to recreate the feeds. However, if this executes too soon (while 
> rebind is still happening), the \{{SshMachineLocation}} may not yet be 
> managed. If that is the case, the feed is not created.
> This is most likely to happen if there are a lot of entities/locations, so 
> iterating over them for rebind takes longer. It is random in that the delay 
> in calling \{{connectSensors}} can sometimes be extremely short (the 
> randomness there is to avoid the thundering herd problem on rebind).
> Although the symptoms are similar to 
> https://issues.apache.org/jira/browse/BROOKLYN-425, the underlying cause is 
> different - therefore treating this as a new issue rather than reopening the 
> old one.

This message was sent by Atlassian JIRA

Reply via email to