I ended up creating 2 PRs: - for JBoss 7: https://github.com/apache/brooklyn-library/pull/149 - for JBoss 6: https://github.com/apache/brooklyn-library/pull/150 (as it is even older than 7)
Best. On Fri, 9 Mar 2018 at 11:23 Aled Sage <[email protected]> wrote: > +1 to deprecating it Thomas. > > Alex, I agree with you in general. In this case, we don't particularly > care about a yaml equivalent of jboss 7 because it's so old. We would > like a yaml blueprint for wildfly [1] in the community at some point. I > thought that someone had done that in the past, but I couldn't find it > when I had a quick look. Also, Wildfly is now at version 12, so likely > the blueprint done previously would need updated anyway. > > Aled > > [1] http://wildfly.org > > > On 09/03/2018 11:16, Alex Heneveld wrote: > > > > go for it. is there a yaml entity in the community we can point > > people to as part of the deprecation? > > > > wherever possible i'd like to replace the system-specific java > > entities like jboss with yaml equivalents in the community (ie outside > > apache brooklyn). > > > > --a > > > > > > On 09/03/2018 10:28, Thomas Bouron wrote: > >> Hi Brooklyners > >> > >> I made a PR yesterday[1] (which as been merged, thanks Geoff) to fix an > >> issue with JBoss 7 entity. As it turns out, JBoss 7 is now EOL and > >> does not > >> work with java 7u171 onward. This is due to the `jboss-module.jar` not > >> being compatible with the newest versions of Java. > >> > >> The patch I made is a trick really but it works: the version of > >> `jboss-module.jar` shipped with JBoss 7.1.1 is `1.1.1.GA`. However, > this > >> particular jar has been updated to `1.1.5.GA` and using this one > >> fixes the > >> issue. While this works, it is still a hacky thing to do therefore I > >> would > >> like to deprecate this entity. > >> > >> Any objection before I do this? > >> > >> Best. > >> > >> [1] https://github.com/apache/brooklyn-library/pull/148 > > > > -- Thomas Bouron • Senior Software Engineer @ Cloudsoft Corporation • https://cloudsoft.io/ Github: https://github.com/tbouron Twitter: https://twitter.com/eltibouron
