Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/153#discussion_r185454798
--- Diff: Jenkinsfile ---
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+node(label: 'ubuntu') {
+ catchError {
+ def environmentDockerImage
+
+ def dockerTag = env.BUILD_TAG.replace('%2F', '-')
+
+ withEnv(["DOCKER_TAG=${dockerTag}"]) {
+ stage('Clone repository') {
+ checkout scm
+ }
+
+ stage('Prepare environment') {
+ echo 'Creating maven cache ...'
+ sh 'mkdir -p ${WORKSPACE}/.m2'
+ echo 'Building docker image for test environment ...'
+ environmentDockerImage =
docker.build('brooklyn:${DOCKER_TAG}')
+ }
+
+ stage('Run tests') {
+ environmentDockerImage.inside('-i --name
brooklyn-${DOCKER_TAG} -v ${WORKSPACE}/.m2:/root/.m2 -v ${WORKSPACE}:/usr/build
-w /usr/build') {
+ sh 'mvn clean install'
+ }
+ }
+
+ // Conditional stage to deploy artifacts, when not building a
PR
+ if (env.CHANGE_ID == null) {
+ stage('Deploy artifacts') {
+ environmentDockerImage.inside('-i --name
brooklyn-${DOCKER_TAG} -v ${WORKSPACE}/.m2:/root/.m2 -v ${WORKSPACE}:/usr/build
-w /usr/build') {
+ sh 'mvn deploy -DskipTests'
+ }
+ }
+
+ // TODO: Publish docker image to
https://hub.docker.com/r/apache/brooklyn/ ?
+ }
+ }
+ }
+
+ // ---- Post actions steps, to always perform ----
+
+ stage('Publish test results') {
+ // Publish JUnit results
+ junit allowEmptyResults: true, testResults:
'**/target/surefire-reports/junitreports/*.xml'
+
+ // Publish TestNG results
+ step([
+ $class: 'Publisher',
+ reportFilenamePattern: '**/testng-results.xml'
+ ])
+ }
+
+ // Conditional stage, when not building a PR
+ if (env.CHANGE_ID == null) {
+ stage('Send notifications') {
+ // Send email notifications
+ step([
+ $class: 'Mailer',
+ notifyEveryUnstableBuild: true,
+ recipients: '[email protected]',
+ sendToIndividuals: false
+ ])
+ }
+
+ // TODO: Build full brooklyn project
--- End diff --
Does this need to be in here? Surely the trigger will be built into the top
level brooklyn build job? I'd have thought it's not up to upstream jobs like
this to decide what downstream jobs need to be triggered, rather it's up to any
number of downstreams to see this job succeeding and then decide to rebuild
themselves?
---
