Github user rdowner commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/975#discussion_r206111336
--- Diff: karaf/features/src/main/feature/feature.xml ---
@@ -274,8 +275,40 @@
<feature name="brooklyn-container-service"
version="${project.version}" description="Brooklyn Container Service and
Location Targets">
<bundle
start-level="85">mvn:org.apache.brooklyn/brooklyn-locations-container/${project.version}</bundle>
+ <feature>brooklyn-core</feature>
+<!-- previously we used these, but they pull in wrong versions - jackson
2.7.5 and snakeyaml 1.17
+ <feature>kubernetes-client</feature>
+ <feature>openshift-client</feature>
+-->
+<!-- these are pulled in elsewhere
+ <bundle
dependency='true'>mvn:javax.validation/validation-api/1.1.0.Final</bundle>
+ <bundle
dependency='true'>mvn:javax.servlet/javax.servlet-api/3.1.0</bundle>
+-->
+<!-- these are wrong version, right version pulled in elsewhere
--- End diff --
Why leave them here, commented out, if they're wrong? Just delete?
---
