GitHub user kemitix opened a pull request:
https://github.com/apache/brooklyn-docs/pull/266
Clean up docs
* fix a few typos
* extract some code blocks to `example_yaml`
* fix loading bash script as tar.gz from url to ensure it is executable
* fix hi netcat example to close the connection at end of file
* wrap jdbc string format in quotes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kemitix/brooklyn-docs review-docs-for-530-rc3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-docs/pull/266.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #266
----
commit d66451f2c534f7964f8aac1d5cfa149adbe61487
Author: Paul Campbell <paul.campbell@...>
Date: 2018-08-22T13:57:38Z
example_yaml: make start.sh executable after extracting
/tmp/brooklyn-...-launching_VanillaSoftwareProce.sh:
line 9: ./start.sh: Permission denied
commit 767a7160e1a032f56034fd19766f24a7e90617a2
Author: Paul Campbell <paul.campbell@...>
Date: 2018-08-22T14:32:10Z
example_yaml: netcat client closes connection after EOF
From the nc(1) man page:
-N shutdown(2) the network socket after EOF on the input. Some servers
require this to finish their work.
Ubuntu would appear to be one such server.
commit c0aaf80f12e0c284c804eb618805221dc5d03d13
Author: Paul Campbell <paul.campbell@...>
Date: 2018-08-24T11:50:16Z
Update to use datastore.creation.script.template.url
commit e8274fddc603dadbba6cf7933d76eb6a0bfcdd4c
Author: Paul Campbell <paul.campbell@...>
Date: 2018-08-24T11:51:56Z
Fix typo in example yaml for dynamicfabric
commit 845339d8cd4398aaa0f8463c52a1835071899c03
Author: Paul Campbell <paul.campbell@...>
Date: 2018-08-24T11:55:59Z
Quote jdbc string format templates
Ampersand (&) in format wasn't being parsed properly.
commit 46fc3814dcb634ebd34afd298554feae33c15309
Author: Paul Campbell <paul.campbell@...>
Date: 2018-08-24T12:59:40Z
Extract Entity Config example to YAML file
Added a name for the deployed application.
commit 37d84333e40041c16efa64d14b47aac14eb0e071
Author: Paul Campbell <paul.campbell@...>
Date: 2018-08-24T13:30:58Z
Extract Entity Constraint example to YAML file
commit ca1cd3f6f52d752ec5cdf92af714050d14d8e4a0
Author: Paul Campbell <paul.campbell@...>
Date: 2018-08-24T14:53:45Z
Extract Entity Config Override example to YAML file
----
---
