Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/999
Looks good - happy to merge, after I've build + run tests locally.
The jenkins PR build is still failing with the error below (I suspect it's
a network connection problem while it's trying to download lots from github; I
wonder if we can use `--depth=1` for PR builds, or if that would mess up
because it wants to check if the PR is mergeable etc):
```
Caused by: hudson.plugins.git.GitException: Command "git fetch --tags
--progress git://github.com/apache/brooklyn-server.git
+refs/pull/*:refs/remotes/origin/pr/*" returned status code 128:
```
It would be good to also expand out the tests in
`ConfigParametersYamlTest`, so that we regression-test it is always calling
`ConstraintSerialization` (currently it just does `required`). I'll look at
adding that, along with some more unit tests I was playing around with in
`ConstraintSerializationTest`.
---
