Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/1002
Eye-balling the changes, they look good. A few things to raise:
1. Would be good to upgrade our jetty.version to 9.4.x (from 9.3.24) to
match karaf's version. But @kemitix has tested with us including both bundle
versions in karaf and it's working. So we can do that separately.
2. A little uncomfortable about having two `pax-web` versions - what needs
6.0.6 explicitly? What version is in karaf 4.2.1?
3. The karaf.plugin.version in 4.1.5 onwards does not respect maven's `-s
/path/to/settings.xml` (as described in
http://karaf.922171.n3.nabble.com/4-1-5-and-Karaf-Maven-Plugin-td4052587.html -
I've been meaning to create a formal bug report for that!). This shouldn't
affect Brooklyn because Apache Jenkins uses the standard location
`~/.m2/settings.xml`, but might impact downstream projects.
I'd like to have some time to build this locally and do some more testing
before we merge it please.
---
