Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/1008
@kemitix I completely agree about the tests being cryptic. Passing four
booleans in a row in a method signature is an anti-pattern: it is hard to read
and very error-prone.
These tests were originally written by Alex - I did some minor improvements
to their readability (see
https://github.com/apache/brooklyn-server/commit/d19d2079b1a2b16c6de8c950b67a2daf0b8d3372).
I decided it was hard to make it much more readable without significantly
increasing the amount of code required.
On balance, because it is a test class and because the methods are private,
it seemed ok to leave the methods as cryptic - unpleasant for code reviewers
looking at a diff, but if you open up the class it's liveable with.
---
