[GitHub] brooklyn-ui pull request #90: DSL editor: allow ref to entity anywhere

[aledsage]

GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-ui/pull/90

    DSL editor: allow ref to entity anywhere

    This change means that the DSL editor will let you choose a reference to an 
entity in any config key (rather than only if the config key is of type 
`Entity`).
    
    This makes it more consistent with the rest of the DSL editor: e.g. if 
generating `attributeWhenReady`, it doesn't type-check the attributes' types to 
filter the view to only those that match the config key's type. This is a good 
thing, because otherwise we'd have to repeat all the type coercion rules in the 
UI, for it to know what is legal!
    
    ---
    I tested this by running `npm run start` in 
brooklyn-ui/ui-modules/blueprint-composer. I chose a couple of arbitrary 
entities, and successfully wired up a config key's value to reference the other 
entity:
    
    <img width="822" alt="dsl-editor-entity-ref" 
src="https://user-images.githubusercontent.com/593113/47419941-30857c00-d775-11e8-9509-2bc87a8fb146.png";>


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-ui 
dsl-editor-allow-entity-ref

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-ui/pull/90.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #90
    
----
commit e8762af21c1567493d491a2e4a5ff26384026941
Author: Aled Sage <aled.sage@...>
Date:   2018-10-24T09:09:18Z

    DSL editor: allow ref to entity anywhere

----


---