Github user grkvlt commented on a diff in the pull request:

    https://github.com/apache/brooklyn-ui/pull/89#discussion_r227783485
  
    --- Diff: 
ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js
 ---
    @@ -130,7 +130,13 @@ export function specEditorDirective($rootScope, 
$templateCache, $injector, $sani
                     open: false
                 }
             };
    -
    +        // allow downstream to configure this controller and/or scope
    +        (composerOverrides.configureSpecEditor || function() {})(this, 
$scope, $element);
    +        var headerTemplate = 
angular.element($templateCache.get('spec-editor/header.html'));
    --- End diff --
    
    Can we move this to the callback instead


---

Reply via email to