Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-ui/pull/91#discussion_r227807161
  
    --- Diff: 
ui-modules/blueprint-composer/app/components/catalog-saver/catalog-saver.directive.js
 ---
    @@ -54,11 +57,17 @@ export function saveToCatalogModalDirective($rootScope, 
$uibModal) {
             link: link
         };
     
    -    function link($scope) {
    +    function link($scope, $element) {
             $scope.buttonText = $scope.config.label || ($scope.config.itemType 
? `Update ${$scope.config.name || $scope.config.symbolicName}` : 'Add to 
catalog');
    +
    +        
$injector.get('$templateCache').put('catalog-saver.modal.template.html', 
modalTemplate);
    --- End diff --
    
    You know that you can inject directly `$templateCache` without using the 
`$injector` service? Might be cleaner as you don't reuse it.


---

Reply via email to