GitHub user kemitix opened a pull request:
https://github.com/apache/brooklyn-server/pull/1013
Partial Fix for Windows Build
Fixes a couple of issues with the Windows build. There are other issues
beyond these fixes that are still breaking the build.
* Under Windows the recursive deletion of directories containing bundles
throws an `IOException` during the test `tearDown` phase causing tests to fail.
Tests now use an new static method `FileUtil.deleteDirectory()` that deletes
the directory and logs, rather than throws, any `IOException`.
* `maven-compiler-plugin` was using the incorrect syntax for configuring
compiling of groovy souce code. This wasn't breaking the build, but was a
simple fix.
* Add a `@DisableOnWindows` annotation for TestNG that will ignore test
methods with this annotation. The annotation requires a reason be given to
explain why. This reason is included in log output indicating that the test is
disabled.
* Disable tests in `BashCommandsIntegrationTest` that require features not
typically available in a normal Windows environment: i.e. an SSH server on
localhost, the `bash` command line, the `whoami` command.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kemitix/brooklyn-server fix-windows-build
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/1013.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1013
----
commit 9f89562caf16b58154c31366d89f54b8bebced21
Author: Paul Campbell <pcampbell@...>
Date: 2018-11-05T10:50:46Z
[rt-felix] embedded framework test survives teardown
When deleting files during teardown, if a temporary file can't be deleted
then the test should not fail for that reason. Log that the file could not
be delete and carry on.
commit fbb6a6f2e678dcaac66a7ad15de701f856823965
Author: Paul Campbell <pcampbell@...>
Date: 2018-11-05T14:05:18Z
[core] embedded framework test survives teardown
When deleting files during teardown, if a temporary file can't be deleted
then the test should not fail for that reason. Log that the file could not
be delete and carry on.
commit c2af743b6c7daa392b1301946e9b5632b4a61fc1
Author: Paul Campbell <pcampbell@...>
Date: 2018-11-05T22:03:15Z
[utils] Extract FileUtil.deleteDirectory() from duplicated code
commit 18f65e1ebffa6bfc55bc2f706098747296ec429c
Author: Paul Campbell <pcampbell@...>
Date: 2018-11-05T22:06:18Z
[core] Fix syntax for maven-compiler plugin
commit c5a851d626cf5069fe06c9dceac174f238892dbb
Author: Paul Campbell <pcampbell@...>
Date: 2018-11-06T10:15:26Z
[test-support] Add @DisableOnWindows annotation for TestNG tests
commit 2ba7ce671973fdf49ad099f3c744b2f38807860c
Author: Paul Campbell <pcampbell@...>
Date: 2018-11-06T10:23:50Z
[core] Disable BashCommandsIntegrationTest test on Windows
----
---
