aledsage commented on a change in pull request #1010: BROOKLYN-605 rebind fails for historic state URL: https://github.com/apache/brooklyn-server/pull/1010#discussion_r248246789
########## File path: utils/common/src/test/java/org/apache/brooklyn/util/javalang/ReflectionsTest.java ########## @@ -24,12 +24,12 @@ import java.lang.reflect.Field; import java.lang.reflect.Method; -import java.util.Arrays; -import java.util.List; +import java.util.*; Review comment: Convention in brooklyn is to not use `.*` imports. (If it were for everything in a nested class, such as you do in `org.apache.brooklyn.core.catalog.internal.CatalogUpgradeScannerTest.Givens.*;` then that makes complete sense. But for things like `java.util...` I'd prefer explicit imports. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
