tbouron commented on a change in pull request #120: tidy logout and other misc
minor changes for new server security model
URL: https://github.com/apache/brooklyn-ui/pull/120#discussion_r252249722
##########
File path: ui-modules/logout/app/index.js
##########
@@ -26,10 +26,11 @@ import brCore from 'brooklyn-ui-utils/br-core/br-core';
import brInterstitialSpinner from
'brooklyn-ui-utils/interstitial-spinner/interstitial-spinner';
import brooklynModuleLinks from 'brooklyn-ui-utils/module-links/module-links';
import brooklynUserManagement from
'brooklyn-ui-utils/user-management/user-management';
+import brServerStatus from 'brooklyn-ui-utils/server-status/server-status';
import mainState from './views/main/main.controller';
-angular.module('app', [ngAnimate, ngCookies, uiRouter, brCore,
brInterstitialSpinner, brooklynModuleLinks, brooklynUserManagement, mainState])
+angular.module('app', [ngAnimate, ngCookies, uiRouter, brCore,
brInterstitialSpinner, brServerStatus, brooklynModuleLinks,
brooklynUserManagement, mainState])
Review comment:
Why do we want the `brServerStatus` directive in there? I don't think it
useful to have on the logout page
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
