ahgittin commented on issue #118: [WIP] Parameter UI additions URL: https://github.com/apache/brooklyn-ui/pull/118#issuecomment-467386727 This will be really useful, defining parameters for use when adding to the catalog. Early review of functionality: * "Parameters" only need to be defined on the root node I think, should not be available elsewhere (what would be the use case for that?) * I guess the non-JSON edit mode is being worked on? * Once a parameter is added, it should be available in the config section (probably) Two bigger related questions: * Should we replace the funnel and plus with a single "search/add" icon (eg a magnifying glass with a + in the glass?) which combines the two modes? (Both for config and for parameters.) * Should we also have catalog metadata on the root node, and parameters would be part of that? They could be useful even when not saving to catalog (to define a value once and use it in multiple places) but that could be done with ad hoc config keys, and for the most part parameters will be set when saving to catalog, and I've not been a fan of that info only appearing when you get a popup dialog. @tbouron @aledsage thoughts on ^ ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
