tbouron commented on a change in pull request #124: DSL Viewer ignored
literals; this fixes that and tidies the code a bit
URL: https://github.com/apache/brooklyn-ui/pull/124#discussion_r260319106
##########
File path:
ui-modules/blueprint-composer/app/components/dsl-viewer/dsl-viewer.template.html
##########
@@ -46,6 +48,10 @@
<dsl-viewer dsl="argument"></dsl-viewer>
</li>
</ol>
-</span>
+ </span>
-<span ng-if="isLiteralDsl(dsl)">{{dsl.name}}</span>
\ No newline at end of file
+ <span ng-switch-default>
+ {{ getMode(dsl) }}: {{ dsl }}
Review comment:
the space here is very small, adding the mode is a waste of valuable real
estate. We already have an icon to symbolise what type this is, adding the mode
is an unnecessary repetition. I think it should be dropped.
You could however add that has a hover title of tooltip
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
