ahgittin commented on issue #129: UI for defining parameters URL: https://github.com/apache/brooklyn-ui/pull/129#issuecomment-477229926 did some testing and it all works (6 is happy), except a default value of `''` is being set for things so `required` has no effect. i've fixed that such that we drop fields if empty (including constraints) except for default value we're slightly more clever if `""` is set in yaml; see last commit for details. this leaves two things to consider: * 5 -- i can't think of a use case for including params in the config section, so while logically it is valid to include them, practically i see no reason to, it just makes noise and confusion; setting a `default` is clearer than setting a value and they achieve the same things * 7 -- not one for now but as mentioned in #118 we might want to merge some of the catalog metadata into the "Application" widget instead of the modal "Save" popup, with an option there "Save this as a catalog item" and parameters only appears if that is checked
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
