tbouron commented on a change in pull request #129: UI for defining parameters
URL: https://github.com/apache/brooklyn-ui/pull/129#discussion_r270353652
##########
File path:
ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js
##########
@@ -639,9 +777,9 @@ export function specEditorDirective($rootScope,
$templateCache, $injector, $sani
};
specEditor.isDslWizardButtonAllowed = (key, index, nonModelValue) => {
let val = scope.model.config.get(key);
- if (specEditor.defined(val) && specEditor.defined(index) &&
index!=null) val = val[index];
- if (!specEditor.defined(val) || val===null || val==='') val =
nonModelValue;
- if (!specEditor.defined(val) || val===null || val==='') return
true;
+ if (specEditor.defined(val) && specEditor.defined(index) && index
!= null) val = val[index];
Review comment:
```suggestion
if (specEditor.defined(val) && specEditor.defined(index) &&
index !== null) val = val[index];
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
