tbouron commented on a change in pull request #130: Fix entitlement messages
URL: https://github.com/apache/brooklyn-ui/pull/130#discussion_r270418848
##########
File path:
ui-modules/app-inspector/app/views/main/inspect/summary/summary.controller.js
##########
@@ -188,7 +188,11 @@ export function summaryController($scope, $state,
$stateParams, $q, $http, brSna
entityApi.updateEntityName(applicationId, entityId,
this.name).then((response)=> {
vm.entity.name = vm.name;
}).catch((error)=> {
- brSnackbar.create('Cannot update entity name: the entity [' +
entityId + '] is undefined');
+ if(error.data && error.data.error === 403){
Review comment:
Good point about the REST API. But using your argument, it should then be
applied to **all endpoints**, not just this one. I think it can be done
globally though, like an interceptor of some kind, but it is outside on the
scope of this PR IMO.
So I would remove it for now, but create a JIRA ticket to track this task.
How does it sound @jcabrerizo ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
