tbouron commented on a change in pull request #1061: Granularity entitlement
control
URL: https://github.com/apache/brooklyn-server/pull/1061#discussion_r274306943
##########
File path:
rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/PolicyResource.java
##########
@@ -129,6 +146,11 @@ public Response destroy(String application, String
entityToken, String policyTok
Entity entity = brooklyn().getEntity(application, entityToken);
Policy policy = brooklyn().getPolicy(entity, policyToken);
+ if (!Entitlements.isEntitled(mgmt().getEntitlementManager(),
Entitlements.DELETE_POLICY, policy)) {
+ throw WebResourceUtils.forbidden("User '%s' is not authorized to
remove policy '%s'",
Review comment:
The message should use `delete` instead of `remove` for consistency
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
