jcabrerizo commented on issue #77: Allow sent user defined headers and omit credentials if not needed URL: https://github.com/apache/brooklyn-client/pull/77#issuecomment-496257728 Hi @geomacy thank you very much for your comments. I think you are right. I wrote the header param because I thought t was a good idea but it also could create some risk. Now it using the format that you proposed. Following your idea of sending the `Authorization` header composed if the `authType` value and the stored credentials, I removed the `brooklynUser` and `brooklynPass` from the network package, and now, in its place, there is a more open `credentials`. If basic auth is chosen, it will store the base64 encode of the user and password, as we are doing in the persistence file. Please, let me know if I miss something. This is one of my first works with GO
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
