I'm not totally sure how the jenkins build is set up but I assume it is using a docker image built using the Dockerfile in apache/brooklyn? If I try to build that locally I end up with an image with Docker 1.7.4 so possibly as a quick fix we could replace the current image with an updated one. But is is installing docker using apt-get install do-lang so I assume it would be a bigger change to move to 1.12.
I'll try running the build locally against Geoff's PR using the docker image I just built to check whether that works. That way we can consider splitting the big version change out into a separate change. On Fri, 9 Aug 2019 at 10:50, John McCabe <[email protected]> wrote: > Regarding Go, I'd be inclined to jump to 1.12 asap. > > On Fri, Aug 9, 2019, 9:34 AM Geoff Macartney <[email protected]> > wrote: > > > Hm that's a thought. I'll look at that, but the question on Go version > > still stands, I'd say, irrespective of this particular issue. What do you > > think? > > > > G > > > > On Fri, 9 Aug 2019 at 00:16, John McCabe <[email protected]> wrote: > > > > > Hi Geoff, > > > Have you looked at the jsonpath package used by kubernetes. > > > > > > https://github.com/kubernetes/client-go/tree/master/util/jsonpath > > > > > > It may be a better choice than an implementation with a single > > contributor. > > > Best, > > > John > > > > > > > > > On Thu, Aug 8, 2019 at 10:48 PM Geoff Macartney < > > [email protected] > > > > > > > wrote: > > > > > > > Hi all, > > > > > > > > I raised https://github.com/apache/brooklyn-client/pull/78 to update > > the > > > > jsonpath package (following the changes back in > > > > https://github.com/apache/brooklyn-client/pull/68), but I see the > > build > > > > has > > > > broken on Jenkins. It turns out the package I wanted to use requires > Go > > > 1.7 > > > > at least, see comment on PR. We currently use Go 1.6 on Jenkins. > > > > > > > > I think it's probably about time we updated to a more recent Go > anyway. > > > > Would anyone object if I updated the README to specify a more recent > > > > version? Could jump to the current 1.12, or just go as far as 1.11? > > > > > > > > If that's OK, how do we go about getting the version of Go on the > > > > build.apache.org Jenkins servers updated? > > > > > > > > Geoff > > > > > > > > > > -- Duncan Grant Lead Software Engineer *Cloudsoft <https://cloudsoft.io/> *| Bringing Business to the Cloud GitHub: https://github.com/duncangrant/
