Ha, thanks Peter, no worries.

Glad to hear you're getting there with the secrets supplier, good luck.

Geoff

On Tue, 3 Sep 2019 at 02:54, Peter Abramowitsch <[email protected]>
wrote:

> Hi Geoff.  I gave it a shot, but am not familiar with the go language to be
> of any use as a peer reviewer, nor am I familiar with the internals of the
> client.
>
> Sorry.
> I feel I owe you one, after your patient help with all my questions.
>
> ((I'm still fighting with my external secrets supplier.. and bit by bit I
> am winning.  I could find on how the property Map created for the supplier
> in brooklyn.cfg is transformed into the supplier's required (Object ...
> args) constructor.  The unit test  bypasses that mode of injection.  Time
> for lots of debug statements))
>
> Peter
>
> On Mon, Sep 2, 2019 at 9:16 AM Geoff Macartney <[email protected]>
> wrote:
>
> > Hi all,
> >
> > Any takers to review/approve
> > https://github.com/apache/brooklyn-client/pull/78?
> >
> > Thanks
> > Geoff
> >
>

Reply via email to