geomacy commented on issue #1066: JcloudsLocation: don’t expose cloud identity 
in toString()
URL: https://github.com/apache/brooklyn-server/pull/1066#issuecomment-538085018
 
 
   > What about instead if `Strings.isNonBlank(getDisplayName())` then that's 
the only thing we show inside the `[`...`]`, whereas if it is blank we show all 
the other details (identity, config description, id)?
   > 
   > This way in a well-configured env user will only see nice things and with 
good names it will be unambiguous, but in other uses we aren't hiding info that 
is useful to identify the location -- specifically if I have multiple AWS 
locations and I haven't given them names I think the identify is useful.
   
   +1, sounds good to me

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to