aledsage commented on a change in pull request #1067: improved templates
support, and jackson bump
URL: https://github.com/apache/brooklyn-server/pull/1067#discussion_r352670363
##########
File path: utils/rest-swagger/pom.xml
##########
@@ -105,6 +105,24 @@
<dependency>
<groupId>com.fasterxml.jackson.dataformat</groupId>
<artifactId>jackson-dataformat-xml</artifactId>
+ <exclusions>
+ <exclusion>
+ <!-- jackson above v 2.10.0 wants 6.0 of woodstox, but cxf
used elsewhere is only at 5.x -->
+ <groupId>com.fasterxml.woodstox</groupId>
Review comment:
We should be really careful about using these kinds of excludes. They only
apply to the maven build.
Excluding this tell us that jackson 2.10.0 has been compiled against a
different version of woodstox than is shipped in karaf (and in the Brooklyn
distro), so we risk `NoSuchMethoError`s etc.
These kind of exclusions are a worry to me: it's safer to just use the same
version, if possible.
Also, they only apply to the maven build and not to karaf. Depending on what
the feature.xml says, we might end up with both or just the pre-installed
version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
