aledsage opened a new pull request #1092: URL: https://github.com/apache/brooklyn-server/pull/1092
This pull request builds on and extends https://github.com/apache/brooklyn-server/pull/1039. The original branch for that PR was deleted. The git fu to get a branch with these commits was: ``` git fetch upstream pull/1039/head:bump-bouncycastle git checkout bump-bouncycastle git pull --rebase ```` --- The build still has the following unit test failures: ``` Tests run: 2366, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 105.431 sec <<< FAILURE! - in TestSuite testInjectCertificateAuthority(org.apache.brooklyn.util.core.crypto.SecureKeysAndSignerTest) Time elapsed: 0.181 sec <<< FAILURE! java.lang.AssertionError: expected [true] but found [false] at org.apache.brooklyn.util.core.crypto.SecureKeysAndSignerTest.testInjectCertificateAuthority(SecureKeysAndSignerTest.java:89) ``` As per @kemitix's comment (https://github.com/apache/brooklyn-server/pull/1039#issuecomment-462750504), bumping to sshj 0.27 fixed it - but then he rolled it back to 0.22 because: ``` This avoids an issue where sshj, >= v0.23.0, is broken in OSGi environments, as it uses a class in a private package in a child dependency, eddsa. In v0.23.0, sshj upgrdes to use 0.2.0 of eddsa where this package is made private. ``` This still needs further investigation and fixed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
