ahgittin commented on pull request #1100:
URL: https://github.com/apache/brooklyn-server/pull/1100#issuecomment-633462045


   Awesome stuff!
   
   Hellish dependencies.  But if you got it working, let's merge once comments 
are addressed.
   
   Mainly it's comments to help us in future though there is one bit about 
cross-platform builds that needs to be checked.
   
   In future it might be nicer to jarjar the odd helm deps in a separate 
project rather than pull them all in here via OSGi.  But not worth the effort 
if you have it working.
   
   One other question, do you have an Apache contributor license agreement 
@iuliana ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to