ahgittin commented on a change in pull request #1144:
URL: https://github.com/apache/brooklyn-server/pull/1144#discussion_r570165557
##########
File path:
core/src/main/java/org/apache/brooklyn/util/core/osgi/BundleMaker.java
##########
@@ -269,7 +269,8 @@ private void writeZipEntriesFromFile(ZipOutputStream zout,
File existingZip, Pre
@Deprecated
public Bundle installBundle(File f, boolean start) {
try {
- Bundle b = Osgis.install( framework, "file://"+f.getAbsolutePath()
);
+
+ Bundle b = Osgis.install( framework, f.toURI().toString() );
Review comment:
suspicious
##########
File path:
core/src/test/java/org/apache/brooklyn/core/config/external/PropertiesFileExternalConfigSupplierTest.java
##########
@@ -68,11 +68,6 @@ public void testFromPropertiesJavaFileUrl() throws Exception
{
doTestFromProperties(f -> f.toURI().toString());
}
- @Test
- public void testFromPropertiesTwoSlashAndPathUrl() throws Exception {
Review comment:
this is a useful test
##########
File path:
launcher/src/test/java/org/apache/brooklyn/launcher/BrooklynLauncherRebindCatalogOsgiTest.java
##########
@@ -254,8 +254,8 @@ public void testRebindWithSystemBundleInCatalog() throws
Exception {
// Launch brooklyn, where persisted state now includes the initial
catalog's bundle
startT2(newLauncherForTests(initialBomFile.getAbsolutePath()));
- // Should not have replaced the original "system bundle"
- assertOnlyBundle(reusedFramework, bundleName, pseudoSystemBundle);
+ // FIXME Should we have replaced the original "system bundle" ???
+ assertBundleExists(reusedFramework, bundleName,
pseudoSystemBundle);
Review comment:
feels wrong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
