algairim commented on a change in pull request #197:
URL: https://github.com/apache/brooklyn-ui/pull/197#discussion_r612437052
##########
File path: ui-modules/catalog/app/views/catalog/catalog.template.html
##########
@@ -165,7 +176,7 @@ <h4>No results matching current filters</h4>
</li>
</ul>
- <ul class="list-group list-group-types" ng-show="state.view ===
'types'">
+ <ul class="list-group list-group-types" ng-if="state.view ===
'types'">
Review comment:
Same comment applies here, see above.
##########
File path: ui-modules/catalog/app/views/catalog/catalog.template.html
##########
@@ -69,7 +69,7 @@
</div>
<div class="col-md-12">
- <ul class="list-group list-group-bundles" ng-show="state.view ===
'bundles'">
+ <ul class="list-group list-group-bundles" ng-if="state.view ===
'bundles'">
Review comment:
ng-if removes the whole thing from the DOM tree, I tried it - it is much
slower, I would keep ng-show for performance reasons. State can be switched by
click, does not make sense to modify DOM tree on every switch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
