ahgittin commented on a change in pull request #196:
URL: https://github.com/apache/brooklyn-ui/pull/196#discussion_r613163661
##########
File path: ui-modules/app-inspector/app/components/stream/stream.template.html
##########
@@ -19,14 +19,38 @@
<loading-state error="error" ng-if="stream === undefined"></loading-state>
<div ng-show="stream.length >= 0">
- <pre ng-show="stream.length > 0">{{stream}}</pre>
+ <pre ng-show="stream.length > 0 && !isFilterContent()"
class="auto-scrollable">{{stream}}</pre>
+ <pre ng-show="stream.length > 0 && isFilterContent()"
class="auto-scrollable"><pre ng-repeat="item in filteredStream track by
item.id" ng-show="isDisplayFormattedItem(item)" class="log-section"
ng-class="getFormattedItemLogLevel(item)">{{item.text}}</pre><p
ng-show="!isDisplayTrace && !isDisplayDebug && !isDisplayWarning &&
!isDisplayError" class="text-center"><i>(select filter)</i></p></pre>
<pre ng-show="stream.length == 0" class="text-center"><i>(no
content)</i></pre>
-
<div class="log-actions">
- <span class="log-autoupdate log-action" ng-click="autoUpdate =
!autoUpdate" ng-class="{'active': autoUpdate}"
- uib-tooltip="{{ autoUpdate ? 'Disable' : 'Enable' }} auto-update"
tooltip-placement="top" tooltip-popup-delay="500" tooltip-append-to-body="true">
- <i class="fa fa-refresh"></i></span>
- <span class="log-tail log-action" ng-click="tail = !tail"
ng-class="{'active': tail}"
+
+ <!-- Content filtering -->
+ <span class="log-action" ng-click="isDisplayOther = !isDisplayOther"
ng-class="{'active': isDisplayOther, 'hidden': !isFilterContent()}"
+ uib-tooltip="{{ isDisplayOther ? 'Hide' : 'Show' }} other"
tooltip-placement="top" tooltip-popup-delay="500" tooltip-append-to-body="true">
Review comment:
would be nice to say in tooltip more than just `Show/Hide` but also what
the icon means, how many lines (if easy), and in the case of ther streams if
there are other streams
* `Show trace messages (480 lines)`
* `Hide other streams (238 lines): custom1, custom2`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
