ahgittin edited a comment on pull request #1161: URL: https://github.com/apache/brooklyn-server/pull/1161#issuecomment-819511198
looking at the UI PR https://github.com/apache/brooklyn-ui/pull/196 you are showing the win/powershell filter controls on any stream that looks like powershell CLI XML. so here i think we don’t need a special stream for winrm , we can just use the default behaviour of sending it in stderr … and the UI will figure out it to render it as CLI XML. UPDATE - never mind - i see we are still relying on the backend to pre-process the CLI XML for us, so we need the `winrm` stream for that processed CLI XML variant; the UI wouldn't do the right thing with unprocessed CLI XML in `stderr`. maybe worth a comment to the effect that it might be better in future to do no processing on the backend, and let the front-end know how to split un-pre-processed CLI XML, in which case we could just send `stderr`. (but totally fine how it is working, and not worth the effort to do this change right now.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
