duncangrant commented on a change in pull request #211:
URL: https://github.com/apache/brooklyn-ui/pull/211#discussion_r644866891
##########
File path: ui-modules/login/app/views/main/main.controller.js
##########
@@ -47,18 +47,28 @@ export function loginStateController($scope, $http,
$window, brBrandInfo) {
$scope.$emit(HIDE_INTERSTITIAL_SPINNER_EVENT);
$scope.getBrandedText = brBrandInfo.getBrandedText;
+ let loginController = this;
+ loginController.error = {};
+
+ var testAuthReq = {
+ method: 'HEAD',
+ url: '/v1/server/up/extended'
+ }
+
+ // If the user is already logged in then redirect to home
+ $http(testAuthReq).then( () => {$window.location.href = '/';} );
+
$scope.login = (user)=> {
var req = {
- method: 'GET',
- url: '/',
+ method: 'HEAD',
+ url: '/v1/server/up/extended',
headers: {
'Authorization': 'Basic ' + btoa(user.name +":" +
user.password)
}
}
// ui registry metadata
$http(req)
- .then(function () {
- $window.location.href = '/';
- });
+ .then(() => { $window.location.href = '/'; },
+ () => { $window.alert("Login Failed") ;
loginController.error.loginFailed = "Login Failed" });
Review comment:
Alerting works here but feels old / odd and would be better inline but I
can't see how to get the loginFailed error to appear on. the form,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
