zan-mateusz commented on a change in pull request #1185:
URL: https://github.com/apache/brooklyn-server/pull/1185#discussion_r648196317
##########
File path:
core/src/main/java/org/apache/brooklyn/core/mgmt/ha/HighAvailabilityManagerImpl.java
##########
@@ -999,6 +1000,15 @@ public ManagementPlaneSyncRecord
loadManagementPlaneSyncRecord(boolean useLocalK
return record;
}
+ private boolean updateLastManagementPlaneSyncRecordWithLocalKnowledge() {
+ if (lastSyncRecord!=null) {
+ lastSyncRecord =
updateManagementPlaneSyncRecordWithLocalKnowledge(lastSyncRecord);
+ return true;
+ } else {
+ return false;
Review comment:
We don't need to return value for the particular scenario this change
addresses (as it is then retrieved via a separate API call). In any case it can
be retrieved by calling getLastManagementPlaneSyncRecord() so I think it is
not necessary, happy to be proven wrong of course
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
