[GitHub] [brooklyn-server] duncangrant commented on a change in pull request #1202: Adds an attributes map on WebEntitlementContext to handle user roles

[GitBox]

duncangrant commented on a change in pull request #1202:
URL: https://github.com/apache/brooklyn-server/pull/1202#discussion_r670513578



##########
File path: 
core/src/main/java/org/apache/brooklyn/core/mgmt/entitlement/WebEntitlementContext.java
##########
@@ -38,16 +48,25 @@
     final String requestUniqueIdentifier;
     
     public WebEntitlementContext(String user, String sourceIp, String 
requestUri, String requestUniqueIdentifier) {
+        this(user, sourceIp, requestUri, requestUniqueIdentifier, new 
HashMap<>());

Review comment:
       There's an inconsistency with the initialisation of attributes - here 
it's a hashmap and later it's a mutablemap




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org