ahgittin commented on a change in pull request #1202:
URL: https://github.com/apache/brooklyn-server/pull/1202#discussion_r671160160
##########
File path:
core/src/main/java/org/apache/brooklyn/core/mgmt/entitlement/WebEntitlementContext.java
##########
@@ -21,15 +21,24 @@
import org.apache.brooklyn.api.mgmt.entitlement.EntitlementContext;
import org.apache.brooklyn.util.javalang.JavaClassNames;
+import java.util.HashMap;
+import java.util.Map;
+
/**
* Indicates an authenticated web request as the entitlements context;
* note user may still be null if no authentication was requested
*/
public class WebEntitlementContext implements EntitlementContext {
+ public static final String ENTITLEMENTS_ATTRIBUTES =
"brooklyn.entitlements.attributes";
+
+ public static final String USER_ROLES = "brooklyn.entitlements.user.roles";
Review comment:
are these `ROLES` or `GROUPS` ? when we fetch we call them groups.
should be consistent everywhere. personally i prefer groups. maybe worth a
comment in the code to indicate these are sometimes in LDAP called roles (if
that's true?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
