jathanasiou commented on a change in pull request #254:
URL: https://github.com/apache/brooklyn-ui/pull/254#discussion_r673175791
##########
File path:
ui-modules/app-inspector/app/components/providers/entity-api.provider.js
##########
@@ -79,8 +79,9 @@ function EntityApi($http, $q) {
return $http.get('/v1/applications/' + applicationId + '/entities/' +
entityId + '/config', {observable: true, ignoreLoadingBar: true});
}
- function getEntityConfigState(applicationId, entityId, skipResolution) {
- return $http.get('/v1/applications/' + applicationId + '/entities/' +
entityId +
`/config/current-state?suppressSecrets=true&skipResolution=${!!skipResolution}`,
{observable: true, ignoreLoadingBar: true});
+ function getEntityConfigState(applicationId, entityId, options) {
Review comment:
Can be cleaner by using string templates, native object
deconstruction+extension and default arg value.
```
function getEntityConfigState(applicationId, entityId, options={}) {
return $http.get(
`/v1/applications/${applicationId}/entities/${entityId}/config/current-state`,
{ ...options, observable: true, ignoreLoadingBar: true }
);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
