jathanasiou commented on a change in pull request #256:
URL: https://github.com/apache/brooklyn-ui/pull/256#discussion_r680948494
##########
File path: ui-modules/blueprint-composer/app/components/dsl-editor/dsl-editor.js
##########
@@ -92,6 +92,8 @@ export function dslEditorDirective($rootScope, $filter, $log,
brUtilsGeneral, bl
let name = item.name;
if (attrs.length > 0) {
name += ` (${attrs.join(', ')})`;
+ } else {
Review comment:
Might be cleaner as
```
let { name, entity, id } = item;
name += (attrs.length > 0)
? ` (${attrs.join(', ')})`
: ` (${entity.id || id})`;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
