jathanasiou commented on a change in pull request #274:
URL: https://github.com/apache/brooklyn-ui/pull/274#discussion_r699212493
##########
File path:
ui-modules/app-inspector/app/views/main/inspect/summary/summary.template.html
##########
@@ -86,11 +86,19 @@ <h2 ng-if="vm.entity" class="entity-name">
<div ng-if="vm.location.items">
<div ng-if="vm.location.items.length !== 0 || !vm.location.multi">
- <p>This entity is running on <em><ng-pluralize
count="vm.location.items.length" when="{'0': 'no locations', 'one': '{}
location', 'other': '{} locations'}"></ng-pluralize></em></p>
+ <p>This entity is associated with <em><ng-pluralize
count="vm.location.items.length" when="{'0': 'no locations', 'one': 'this
location {} ', 'other': 'these locations'}"></ng-pluralize></em></p>
<ul>
<li ng-repeat="item in vm.location.items track by item.id">
- <strong>{{item.config['spec.final'] |
specToLabel:vm.metadata}}</strong>
- <span ng-if="item.config.availabilityZone">in
<code>{{item.config.availabilityZone}}</code> availability zone</span>
+ <span ng-if="item.id"> Location Id: <strong>{{item.id
| specToLabel:vm.metadata}}</strong> </span>
+ <ul>
+ <li ng-if="item.name"> <span> Name: {{item.name |
specToLabel:vm.metadata}}</span> </li>
Review comment:
Consider using CSS rules instead for spacing/padding eg
```
<ul class="location-items">
<li ng-repeat="item in vm.location.items track by item.id">
<span ng-if="item.id">Location Id: <strong>{{item.id |
specToLabel:vm.metadata}}</strong></span>
<ul>
<li ng-if="item.name"><span> Name: {{item.name |
specToLabel:vm.metadata}}</span></li>
...
```
```
.location-items {
li > span {
padding: 0px 1em;
}
}
```
Same logic could be applied to the double spaces by further HTML element
structuring, if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
