ahgittin commented on a change in pull request #1269:
URL: https://github.com/apache/brooklyn-server/pull/1269#discussion_r739292082
##########
File path:
core/src/main/java/org/apache/brooklyn/core/objs/BasicSpecParameter.java
##########
@@ -269,7 +271,7 @@ public String toString() {
.constraint(constraint)
.runtimeInheritance(runtimeInheritance)
.typeInheritance(typeInheritance)
- .reconfigurable(isReconfigurable);
+ .reconfigurable((isReconfigurable!=null) ?
isReconfigurable : false);
Review comment:
would be better to do `if (isReconfigurable!=null)
builder.reconfigurable(isReconfigurable);` rather than repeat the default here
(in case the default changes in future)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
