ahgittin commented on code in PR #323:
URL: https://github.com/apache/brooklyn-ui/pull/323#discussion_r889937844


##########
ui-modules/blueprint-composer/app/components/util/d3-blueprint.js:
##########
@@ -364,7 +364,9 @@ export function D3Blueprint(container, options) {
     function onKeyUp() {
         d3.event.stopPropagation();

Review Comment:
   Isn't the usual pattern to stop propagation only if the event is handled?
   
   Happy to leave like this but one to watch if there are any related issues.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to