zan-mateusz commented on code in PR #1425:
URL: https://github.com/apache/brooklyn-server/pull/1425#discussion_r2716831037
##########
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/BrooklynDslCommon.java:
##########
@@ -477,8 +478,16 @@ public final static class DslLiteral extends
BrooklynDslDeferredSupplier<Object>
private DslLiteral() { this(null); }
public DslLiteral(Object input) {
- this.literalString = input instanceof String ? (String)input :
null;
- this.literalObjectJson = (input==null || input instanceof String)
? null : Jsonya.render(input);
+ this(input instanceof String ? (String)input : null, (input==null
|| input instanceof String) ? null : Jsonya.render(input));
+ }
+ protected DslLiteral(String literalString, String literalObjectJson) {
+ this.literalString = literalString;
+ this.literalObjectJson = literalObjectJson;
+ }
+ @Override public BrooklynDslDeferredSupplier<?>
applyModificationVisitor(Function<BrooklynDslDeferredSupplier<?>,BrooklynDslDeferredSupplier<?>>
visitor) {
Review Comment:
same as above
##########
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/BrooklynDslCommon.java:
##########
@@ -567,6 +576,11 @@ protected static class DslUrlEncode extends
BrooklynDslDeferredSupplier<String>
public DslUrlEncode(Object arg) {
this.arg = arg;
}
+ @Override public BrooklynDslDeferredSupplier<?>
applyModificationVisitor(Function<BrooklynDslDeferredSupplier<?>,BrooklynDslDeferredSupplier<?>>
visitor) {
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
