jcabrerizo opened a new pull request, #1440:
URL: https://github.com/apache/brooklyn-server/pull/1440
Two small hardening changes to REST-facing input handling:
- `ApplicationResource.createFromYaml`: when a blueprint is given as a
URL, restrict the server-side fetch to explicit http(s) URLs with a
.yaml/.yml extension (ignoring any query string or fragment), via a
new `BrooklynRestResourceUtils.isUrlSafeForServerSideBlueprintFetch`.
Previously any URL scheme was accepted.
- `LdapSecurityProvider.getUserGroups`: escape values used when
building the LDAP search filters (the looked-up account name, and
the resolved entry name substituted into the configured nested-group
filter), via a new `escapeLdapFilterValue` helper, so they can't
alter the filter's structure.
Both changes are purely additive restrictions/escaping on existing
code paths; no behavioural change for well-formed inputs. Unit tests
added for both new helper methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]