[
https://issues.apache.org/jira/browse/BROOKLYN-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14048680#comment-14048680
]
ASF GitHub Bot commented on BROOKLYN-14:
----------------------------------------
GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/35
BROOKLYN-14: rebind policies in separate phase
- Only add policies+enrichers to entities after all entities have had
their state set, and all relationships (parent-child,
group membership, locations) have been set up
- Also corrects spelling of “doReconsruct” in BasicPolicyRebindSupport
etc
- Improves comments in RebindManagerImpl on rebind’s phases
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn
fix/rebind-addPolicyInSeparatePhase
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/35.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #35
----
commit 59ce9e8b04b4d226436edab96c9e8b4ec2539154
Author: Aled Sage <[email protected]>
Date: 2014-07-01T09:28:33Z
BROOKLYN-14: rebind policies in separate phase
- Only add policies+enrichers to entities after all entities have had
their state set, and all relationships (parent-child,
group membership, locations) have been set up
- Also corrects spelling of “doReconsruct” in BasicPolicyRebindSupport
etc
- Improves comments in RebindManagerImpl on rebind’s phases
----
> Persist+rebind policies and enrichers
> -------------------------------------
>
> Key: BROOKLYN-14
> URL: https://issues.apache.org/jira/browse/BROOKLYN-14
> Project: Brooklyn
> Issue Type: New Feature
> Reporter: Aled Sage
> Fix For: 0.7.0
>
>
> Currently in Brooklyn, rebinding policies+enrichers is supported but is off
> by default - see BrooklynFeatureEnablement [1]. This is because not all
> policies/enrichers/entities have been reviewed to ensure they will work with
> policies being persisted and added on Brooklyn restart (or on brooklyn
> standby node taking over).
> I propose that we change this to persist policies+enrichers. However, we can
> also improve the RebindExceptionHandler [2] to allow behaviour on policy
> rebind to set - defaulting to continue on errors.
> I also want to add a PersistenceExceptionHandler to be called when there are
> errors persisting entities/policies.
> [1]
> https://github.com/apache/incubator-brooklyn/blob/master/core/src/main/java/brooklyn/internal/BrooklynFeatureEnablement.java
> [2]
> https://github.com/apache/incubator-brooklyn/blob/master/api/src/main/java/brooklyn/entity/rebind/RebindExceptionHandler.java
--
This message was sent by Atlassian JIRA
(v6.2#6252)
