Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/42#discussion_r14557420
  
    --- Diff: core/src/main/java/brooklyn/entity/basic/BrooklynConfigKeys.java 
---
    @@ -38,6 +40,13 @@
             "Provides a label which uniquely identifies an installation, used 
in the computation of the install dir; "
             + "this should include something readable, and must include a hash 
of all data which differentiates an installation "
             + "(e.g. version, plugins, etc), but should be the same where 
install dirs can be shared to allow for re-use");
    +    
    +    public static final ConfigKey<String> PRE_LAUNCH_COMMAND = 
ConfigKeys.newStringConfigKey("pre.launch.command",
    +            "Command to be run prior to the launch method being called on 
the driver");
    +    
    +    public static final ConfigKey<String> POST_LAUNCH_COMMAND = 
ConfigKeys.newStringConfigKey("post.launch.command",
    +            "Command to be run after the launch method being called on the 
driver. The implementation in AbstractSoftwareSshDriver "
    --- End diff --
    
    I don't think we need mention `AbstractSoftwareSshDriver` here; this 
description is for end-users, so don't need to include implementation detail. 
That could go in a comment if wanted.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to