Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/25#discussion_r14701324
--- Diff:
software/nosql/src/main/java/brooklyn/entity/nosql/couchbase/CouchbaseSyncGateway.java
---
@@ -0,0 +1,61 @@
+package brooklyn.entity.nosql.couchbase;
+
+import brooklyn.config.ConfigKey;
+import brooklyn.entity.Entity;
+import brooklyn.entity.basic.ConfigKeys;
+import brooklyn.entity.basic.SoftwareProcess;
+import brooklyn.entity.proxying.ImplementedBy;
+import brooklyn.event.AttributeSensor;
+import brooklyn.event.basic.BasicAttributeSensorAndConfigKey;
+import brooklyn.event.basic.PortAttributeSensorAndConfigKey;
+import brooklyn.event.basic.Sensors;
+import brooklyn.util.flags.SetFromFlag;
+
+@ImplementedBy(CouchbaseSyncGatewayImpl.class)
+public interface CouchbaseSyncGateway extends SoftwareProcess {
+
+ @SetFromFlag("version")
+ ConfigKey<String> SUGGESTED_VERSION =
ConfigKeys.newConfigKeyWithDefault(SoftwareProcess.SUGGESTED_VERSION,
+ "1.0-beta3.1");
+
+ @SetFromFlag("downloadUrl")
+ BasicAttributeSensorAndConfigKey<String> DOWNLOAD_URL = new
BasicAttributeSensorAndConfigKey<String>(
+ SoftwareProcess.DOWNLOAD_URL,
"http://packages.couchbase.com/releases/couchbase-sync-gateway/1.0-beta/couchbase-sync-gateway-community_${version}_${driver.osTag}";);
+
+ @SetFromFlag("couchbaseServer")
+ ConfigKey<Entity> COUCHBASE_SERVER =
ConfigKeys.newConfigKey(Entity.class, "couchbaseSyncGateway.couchbaseNode",
+ "Couchbase server node or cluster the sync gateway connects
to");
+
+ @SetFromFlag("serverPool")
+ ConfigKey<String> COUCHBASE_SERVER_POOL =
ConfigKeys.newStringConfigKey("couchbaseSyncGateway.serverPool",
+ "Couchbase Server pool name in which to find buckets",
"default");
+
+ @SetFromFlag("couchbaseServerBucket")
+ ConfigKey<String> COUCHBASE_SERVER_BUCKET =
ConfigKeys.newStringConfigKey("couchbaseSyncGateway.serverBucket",
+ "Name of the Couchbase bucket to use", "sync_gateway");
+
+ @SetFromFlag("couchbaseServerUrl")
+ ConfigKey<String> COUCHBASE_SERVER_URL =
ConfigKeys.newStringConfigKey("couchbaseSyncGateway.couchbaseServerUrl",
--- End diff --
I'm tempted to say we should be using `ConfigKey<URI>` in places like this.
But your code is following same pattern used elsewhere, so not suggesting you
change it here. @grkvlt do you think we should start using `URI`? Changing old
code will break backwards compatibility so hesitant to launch into that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
