Hi Andrew, There are still a few yaml files which contain incorrectly transformed comments, search for [#ftl] in *.yaml.
Svetoslav. -----Original Message----- From: Andrew Kennedy [mailto:[email protected]] Sent: Wednesday, July 9, 2014 6:25 PM To: [email protected] Subject: Re: Hokey cokey on PR #43 All, This has now been successfully re-opened, the reversion has been reverted, and I have updated and re-merged as PR #56, with some additional commits from @aledsage in #55 which fixed a couple of files I missed in the review. All source files and configurations have the appropriate license header, and this formatting should be used as a template for new submissions from now on. Many thanks to @Nakomis for the hard work doing the initial scripted updates and fixes, and apologies for any confusion I caused... Andrew. -- -- andrew kennedy ? engineer : http://cloudsoftcorp.com/developers/ ; On 9 July 2014 14:51, Richard Downer <[email protected]> wrote: > I merged this PR earlier today, in the mistaken belief that review > comments had been made, and handled fully. However grkvlt (Andrew > Kennedy) was still in the process of reviewing it and had further > review comments to make. > > I have now reverted PR #43 so grkvlt can continue. > > My apologies for the inconvenience to anyone who started work off > master, or rebased, during the window between the two events. But > mostly an apology to grkvlt; he was reviewer for the commit and it was > not appropriate for me to jump in as I did. > > Richard. >
