Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/61#discussion_r14808432
--- Diff: utils/common/src/main/java/brooklyn/util/text/Identifiers.java ---
@@ -51,6 +51,9 @@
* in general this is preferable to base64 as is more portable,
* can be used throughout javascript (as ID's which don't allow +)
* or as java identifiers (which don't allow numbers in the first char)
+ *
+ * WARNING: The method is not as random as advertised!
+ * Highly probable to return the same id in the first 2000
attempts.
--- End diff --
The suggestion to put concrete examples of probability is great. I was
considering removing the comment altogether after your comment above about the
birthday paradox, but this would be very useful to add.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
