GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/69
Adds a BrooklynObject super-type, and removes a bunch of duplicated code
Note the `BrooklynObject` is extremely simple just now. The thinking is to
add to that, to remove duplication from Entity+Location+Policy+Enricher, and to
make them more consistent for their API+impl for config etc.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn
refactor/BrooklynObject-superType
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/69.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #69
----
commit 519bc9a8de5443f48472bfff597c41d543c95dd6
Author: Aled Sage <[email protected]>
Date: 2014-07-02T08:34:08Z
Remove duplication from InternalEntityFactory etc
commit 0194580ea36d0a00ab56fa7bbf9ade6b718dfef2
Author: Aled Sage <[email protected]>
Date: 2014-07-02T08:34:37Z
Creating BrooklynObject super-type
- a super type for Entity, Location, Policy and Enricher
commit 91383179bff219989c0f4a4f90d5f3d7e0360e94
Author: Aled Sage <[email protected]>
Date: 2014-07-14T11:47:25Z
Deprecate EntitySpec.id and LocationSpec.id
- Just let the management context decide what the id should be.
- Rebind goes through a different path.
commit e07155ad3fafa6bd6f3bc0ac2060ceaa95426c72
Author: Aled Sage <[email protected]>
Date: 2014-07-14T11:48:46Z
Internal*Factory: remove duplication
- Remove duplication across InternalEntityFactory, InternalPolicyFactory
and InternalLocationFactory
- Remove duplication in callers of InternalEntityFactory.createEntity
commit cbb6e40c55fa7d2e1382fecbfff0d70ff7b4f79f
Author: Aled Sage <[email protected]>
Date: 2014-07-14T14:55:27Z
Remove duplication in rebind code
commit 5ca049eb6497e5698c8e493f928741bb201fa949
Author: Aled Sage <[email protected]>
Date: 2014-07-14T15:09:59Z
Change EntityAdjunct.getName() to getDisplayName()
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
