Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/64#discussion_r14981558
--- Diff:
software/base/src/test/java/brooklyn/entity/pool/AbstractServerPoolTest.java ---
@@ -112,6 +113,10 @@ protected void assertAvailableCountEquals(ServerPool
pool, Integer count) {
assertEquals(pool.getAttribute(ServerPool.AVAILABLE_COUNT), count);
}
+ protected void assertAvailableCountEventuallyEquals(int count) {
+ EntityTestUtils.assertAttributeEqualsEventually(pool,
ServerPool.AVAILABLE_COUNT, count);
--- End diff --
feels like a bike-shed email, better I think just to PR a refactoring where
the common methods do things in a clear and consistent way. perhaps introduce
some assertj tests first and see as that might steer us towards a good idiom.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
